For those that do not buy diamonds, I'd suggest that you save them for things which give long term benefits, such as being able to build & upgrade 2 buildings at once.
Note: the 2nd and 3rd slot in the Medical Lab will be unlocked just by logging in, so best not to spend them on the medical lab slots.
(Having said that, I spend the diamonds to open the 2nd slot, and used the free one to open the 3rd.)
Generally speaking: reviving troops with diamonds is a waste of them, but might be worth while if you have the 75% discount active.
Anything you use them for that moves your game ahead is an OK use, but ideal is something that gives you disproportional advancement. This might mean buying something common / easy, such as 20 more S+D locations, because that happens to be the current active event.
In other words: if you can use diamonds to win more diamonds: that is an exceedingly good use for them.
Likewise: buying the nuke because some guy just zeroed your base might give you lasting satisfaction, even if not highly effective.
This is first and foremost a game, so using them to have fun is never a bad idea.